-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Introduce the sigs.k8s.io/cluster-api/test Go Module #4713
Conversation
COPY test/go.mod go.mod | ||
COPY test/go.sum go.sum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should apply a similar change in the tiltfile, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I investigated this a little bit and given the code at
Lines 155 to 160 in 376dca0
# Prefix each live reload dependency with context. For example, for if the context is | |
# test/infra/docker and main.go is listed as a dep, the result is test/infra/docker/main.go. This adjustment is | |
# needed so Tilt can watch the correct paths for changes. | |
live_reload_deps = [] | |
for d in p.get("live_reload_deps", []): | |
live_reload_deps.append(context + "/" + d) |
With this change we are loosing live reload for go.mod and go.sum
Lines 74 to 75 in 376dca0
"go.mod", | |
"go.sum", |
However, I consider this a small price to pay, so I'm ok with it
/retest |
/kind release-blocking |
lgtm pending rebase |
Signed-off-by: Vince Prignano <[email protected]>
@vincepri: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/milestone v0.4 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Vince Prignano [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #4687