Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 improve clusterctl generate cluster --list-variables #4708

Merged
merged 1 commit into from
Jun 1, 2021
Merged

🌱 improve clusterctl generate cluster --list-variables #4708

merged 1 commit into from
Jun 1, 2021

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
#4645 recently introduced the visualisation of default values for template variables.

This PR slightly improves this by ensuring that for well know variables:

  • if the template defines defaults, those are considered
  • if variables are provided with env vars, those are considered
  • if a default value is provided (no matter if in the template or by other means), the variable is listed a optional; otherwise the variable is listed as required.

/cc @mboersma

@k8s-ci-robot k8s-ci-robot requested a review from mboersma May 31, 2021 16:46
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 31, 2021
@fabriziopandini fabriziopandini force-pushed the improve-clusterctl-list-variables branch from 0986df6 to a770f05 Compare June 1, 2021 09:58
@fabriziopandini fabriziopandini force-pushed the improve-clusterctl-list-variables branch from a770f05 to 4042f37 Compare June 1, 2021 11:54
vincepri
vincepri approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5afb483 into kubernetes-sigs:master Jun 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Jun 1, 2021
mboersma
mboersma approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm++

Nice improvement, I tested it locally.

@fabriziopandini fabriziopandini deleted the improve-clusterctl-list-variables branch June 4, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@mboersma mboersma mboersma approved these changes

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@fabriziopandini @k8s-ci-robot @mboersma @vincepri