Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 fix e2e tests using a single context object #4706

Merged
merged 1 commit into from
Jun 3, 2021
Merged

🌱 fix e2e tests using a single context object #4706

merged 1 commit into from
Jun 3, 2021

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR fixes E2E test so we are using a single context object that gets passed down the chain

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2021
@k8s-ci-robot k8s-ci-robot requested review from enxebre and justinsb May 31, 2021 09:38
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 31, 2021
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@fabriziopandini fabriziopandini mentioned this pull request May 31, 2021
Merged
enxebre
enxebre reviewed May 31, 2021
View reviewed changes
test/e2e/e2e_suite_test.go Outdated Show resolved Hide resolved
@enxebre
Copy link
Member

enxebre commented May 31, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2021
vincepri
vincepri approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2021
@fabriziopandini
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2021
@fabriziopandini
Copy link
Member Author

re running test
/retest

@fabriziopandini
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4f56d8f into kubernetes-sigs:master Jun 3, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Jun 3, 2021
@fabriziopandini fabriziopandini mentioned this pull request Jun 3, 2021
Closed
@fabriziopandini fabriziopandini deleted the fix-e2e-context branch June 4, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre enxebre left review comments

@vincepri vincepri vincepri approved these changes

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@enxebre enxebre

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@fabriziopandini @enxebre @k8s-ci-robot @vincepri