Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Proposal for ClusterClass & managed topologies #4678

Merged
merged 1 commit into from
Jul 7, 2021
Merged

📖 Proposal for ClusterClass & managed topologies #4678

merged 1 commit into from
Jul 7, 2021

Conversation

srm09
Copy link
Contributor

@srm09 srm09 commented May 26, 2021

What this PR does / why we need it:
This PR introduces the proposal for ClusterClass and the concept. of managed topologies.

Which issue(s) this PR fixes:
Fixes #4430

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 26, 2021
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 26, 2021
@srm09 srm09 force-pushed the proposal/cluster-class branch 2 times, most recently from 42c0305 to c30f5c6 Compare May 27, 2021 17:45
CecileRobertMichon
CecileRobertMichon reviewed Jun 2, 2021
View reviewed changes
docs/proposals/202105256-cluster-class-and-managed-topologies.md Show resolved Hide resolved
docs/proposals/202105256-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
docs/proposals/202105256-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
docs/proposals/202105256-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
docs/proposals/202105256-cluster-class-and-managed-topologies.md Show resolved Hide resolved
docs/proposals/202105256-cluster-class-and-managed-topologies.md Show resolved Hide resolved
docs/proposals/202105256-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
docs/proposals/202105256-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
docs/proposals/202105256-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
devigned
devigned suggested changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a bit to grok all of the new structures being introduced, but definitely agree with the value proposition.

Please consider avoiding the use of the "Managed" modifier. "Managed" can be interpreted many different ways and has overloaded uses in cloud platforms. In many places it's used, it seems to provide a distinction without a difference.

Perhaps, where "Managed" is used, it could be culled or replaced with a less overloaded modifier.

docs/proposals/202105256-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
@srm09 srm09 force-pushed the proposal/cluster-class branch from bb31ca2 to b33acf9 Compare June 9, 2021 16:40
@sbueringer
Copy link
Member

/lgtm

CecileRobertMichon
CecileRobertMichon reviewed Jul 6, 2021
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fabriziopandini
Copy link
Member

/lgtm

@enxebre
Copy link
Member

enxebre commented Jul 7, 2021

/lgtm

schrej
schrej approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@schrej schrej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@schrej: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2021
@srm09 @randomvariable
Adds ClusterClass & managed topologies proposal
a63c286 
Signed-off-by: Sagar Muchhal <[email protected]>
Co-authored-by: Cecile Robert-Michon <[email protected]>
Co-authored-by: Naadir Jeewa <[email protected]>
@srm09 srm09 force-pushed the proposal/cluster-class branch from e351369 to a63c286 Compare July 7, 2021 17:12
@srm09
Copy link
Contributor Author

srm09 commented Jul 7, 2021

@CecileRobertMichon Merged the suggestion around a missed rename for ManagedTopology -> Topology. PTAL :)

CecileRobertMichon
CecileRobertMichon reviewed Jul 7, 2021
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2021
CecileRobertMichon
CecileRobertMichon reviewed Jul 7, 2021
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @vincepri @fabriziopandini @enxebre @schrej

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: GitHub didn't allow me to assign the following users: schrej.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @vincepri @fabriziopandini @enxebre @schrej

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

/lgtm

vincepri
vincepri approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 18dbaec into kubernetes-sigs:master Jul 7, 2021
@srm09 srm09 deleted the proposal/cluster-class branch July 7, 2021 21:46
This was referenced Jul 8, 2021
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@sbueringer sbueringer sbueringer left review comments

@dlipovetsky dlipovetsky dlipovetsky left review comments

@jackfrancis jackfrancis jackfrancis left review comments

@randomvariable randomvariable randomvariable left review comments

@enxebre enxebre enxebre left review comments

@pipo02mix pipo02mix pipo02mix left review comments

@devigned devigned devigned requested changes

@vincepri vincepri vincepri approved these changes

@schrej schrej schrej approved these changes

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@enxebre enxebre

@vincepri vincepri

@sbueringer sbueringer

@fabriziopandini fabriziopandini

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

ClusterClass and managed topologies