-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Remove clusterctl --watching-namespace #4666
⚠️ Remove clusterctl --watching-namespace #4666
Conversation
d3a2e94
to
bff86f0
Compare
bff86f0
to
0d4903f
Compare
@fabriziopandini: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test pull-cluster-api-test-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR remove the --watching-namespace from clusterctl and the corresponding field from the clusterctl library, thus starting to remove the options allowing the users to create a management cluster with multiple instances of the same provider, which is a configuration not supported anymore by the tool.
Please note that more cleanup should follow, as described in #4056 (comment), but I'm breaking down the change in smaller PRs in order to make review easier
Which issue(s) this PR fixes:
rif ##4056