Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Remove clusterctl --watching-namespace #4666

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR remove the --watching-namespace from clusterctl and the corresponding field from the clusterctl library, thus starting to remove the options allowing the users to create a management cluster with multiple instances of the same provider, which is a configuration not supported anymore by the tool.

Please note that more cleanup should follow, as described in #4056 (comment), but I'm breaking down the change in smaller PRs in order to make review easier

Which issue(s) this PR fixes:
rif ##4056

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 25, 2021
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 25, 2021
@fabriziopandini fabriziopandini force-pushed the remove-clusterctl-watching-namespace branch from d3a2e94 to bff86f0 Compare May 25, 2021 12:51
@fabriziopandini fabriziopandini force-pushed the remove-clusterctl-watching-namespace branch from bff86f0 to 0d4903f Compare May 25, 2021 15:07
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 25, 2021

@fabriziopandini: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-apidiff-main 0d4903f link /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-test-main

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3c67399 into kubernetes-sigs:master May 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone May 25, 2021
@fabriziopandini fabriziopandini deleted the remove-clusterctl-watching-namespace branch May 26, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants