🐛 Invoke ginkgo in kubetest through entrypoint #4662
Conversation
This change is necessary due to kubernetes/kubernetes#99178 where the conformance image now defines ENTRYPOINT (previously only CMD) which refers to conformance runner. Since this test would like to invoke ginkgo directly, overriding entrypoint is necessary to preserve existing behavior. Signed-off-by: Wilson E. Husin <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
wilsonehusin
changed the title
|
/retest |
k8s-ci-robot
added
the
lgtm
|
@wilsonehusin Thx! Looks like the change is also compatible with older conformance image versions (we also run the 1.19/1.20/1.21 conformance tests in periodics). Unfortunately, we cannot run those jobs presubmit. I'll trigger the full tests which include a test which runs the conformance tests: We could also run the 1.21=>latest upgrade + conformance test presubmit, but that one is broken right now afaik because of a kubeadm change. |
|
@sbueringer: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-e2e-full-main |
|
/lgtm |
@sbueringer yes, it should be backwards compatible! thanks for considering that factor and navigating through the tests 😄 |
|
@wilsonehusin Looks like they are not even executed in our full tests: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/4662/pull-cluster-api-e2e-full-main/1397081405292285952 (see skipped). I'll run your PR locally until the tests start, just to be safe. |
|
@wilsonehusin Looks good locally (with Kubernetes v1.19.1). |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: Wilson E. Husin [email protected]
What this PR does / why we need it:
This change is necessary due to kubernetes/kubernetes#99178 where the
conformance image now defines ENTRYPOINT (previously only CMD) which
refers to conformance runner.
Since this test would like to invoke ginkgo directly, overriding
entrypoint is necessary to preserve existing behavior.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #4660