Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 upgrade kube-rbac-proxy to v0.8.0 #4639

Merged
merged 1 commit into from
May 19, 2021

Conversation

rsmitty
Copy link
Contributor

@rsmitty rsmitty commented May 19, 2021

What this PR does / why we need it:

This PR will update kube-rbac-proxy for the release-0.3 branch. This
helps ensure that the CAPI v0.3.x series can be deployed multi-arch. It is a
straight backport from the commit mentioned below with the exception of
fixing merge conflicts around docs.

(cherry picked from commit aa51850)
Signed-off-by: Spencer Smith [email protected]

@k8s-ci-robot k8s-ci-robot added this to the v0.3 milestone May 19, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 19, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 19, 2021
@sbueringer
Copy link
Member

/retest
(known flake afaik, at least on the default branch)
/lgtm

I'm not really confident about our test coverage in this area (apart from that the controller Pods come up). A bit of manually testing would be appreciated.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2021
- "--metrics-addr=127.0.0.1:8080"
- "--enable-leader-election"
- "--feature-gates=MachinePool=${EXP_MACHINE_POOL:=false}"
- name: kube-rbac-proxy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reset the spacing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, fixed. Thx.

This PR will update kube-rbac-proxy for the release-0.3 branch. This
helps ensure that the CAPI v0.3.x series can be deployed multi-arch. It is a
straight backport from the commit mentioned below with the exception of
fixing merge conflicts around docs.

(cherry picked from commit aa51850)
Signed-off-by: Spencer Smith <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 19, 2021
@sbueringer
Copy link
Member

/lgtm

+/-

I'm not really confident about our test coverage in this area (apart from that the controller Pods come up). A bit of manually testing would be appreciated.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2021
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants