-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 upgrade kube-rbac-proxy to v0.8.0 #4639
Conversation
/retest I'm not really confident about our test coverage in this area (apart from that the controller Pods come up). A bit of manually testing would be appreciated. |
- "--metrics-addr=127.0.0.1:8080" | ||
- "--enable-leader-election" | ||
- "--feature-gates=MachinePool=${EXP_MACHINE_POOL:=false}" | ||
- name: kube-rbac-proxy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reset the spacing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, fixed. Thx.
This PR will update kube-rbac-proxy for the release-0.3 branch. This helps ensure that the CAPI v0.3.x series can be deployed multi-arch. It is a straight backport from the commit mentioned below with the exception of fixing merge conflicts around docs. (cherry picked from commit aa51850) Signed-off-by: Spencer Smith <[email protected]>
/lgtm +/-
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR will update kube-rbac-proxy for the release-0.3 branch. This
helps ensure that the CAPI v0.3.x series can be deployed multi-arch. It is a
straight backport from the commit mentioned below with the exception of
fixing merge conflicts around docs.
(cherry picked from commit aa51850)
Signed-off-by: Spencer Smith [email protected]