-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Update controller runtime to v0.9.0-beta.5 #4638
Conversation
nit: it'd be nice to add a link to the relevant controller runtime issue/PR in the PR desc |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
/hold for next release |
@vincepri just a ping which is at least a bit related with controller-runtime and which version we will use in our release. |
@sbueringer Wasn't aware of that PR, although it seems it has stalled a bit |
@vincepri Yup, problem is, if this isn't fixed, controller runtime sends requests for a Oh, I just realized that we are not using MultiNamespaceCache, I though we were. Okay so then we're not affected by this bug. |
/hold cancel |
/retest |
This change fixes a bug where the conversion webhooks were not actually being registered and running with envtest. Signed-off-by: Vince Prignano <[email protected]>
/lgtm |
🌱 Update controller runtime to v0.9.0-beta.5
What this PR does / why we need it:
This change fixes a bug where the conversion webhooks were not actually
being registered and running with envtest.
Related CR PR: kubernetes-sigs/controller-runtime#1532
/milestone v0.4
/area dependency