🌱 Refactor tests to plain go in controllers #4615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
enxebre
reviewed
May 14, 2021
enxebre
reviewed
May 14, 2021
enxebre
reviewed
May 14, 2021
mboersma
force-pushed
the
go-test-controllers
branch
from
c5e7e57 to
40b331a
Compare
enxebre
reviewed
May 17, 2021
mboersma
force-pushed
the
go-test-controllers
branch
from
40b331a to
a33cca5
Compare
mboersma
force-pushed
the
go-test-controllers
branch
from
a33cca5 to
34a6493
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Refactors the tests in the controllers package to use plain Go testing instead of ginkgo.
Which issue(s) this PR fixes:
Fixes #4588
Notes:
This is a big PR, although I think the changes fall into obvious patterns. But please let me know if I should break it up to make reviewing easier.