🌱 Cleanup unused variable in bootstrap/kubeadm/api/v1alpha4/kubeadmconfig_webhook.go

[chymy]

What this PR does / why we need it:
The variable MissingFileSourceMsg is not used in bootstrap/kubeadm/api/v1alpha4/kubeadmconfig_webhook.go.
If file.Content and file.ContentFrom are allowed to be nil at the same time, the MissingFileSourceMsg variable is redundant. Otherwise, we should verify that file.Content cannot be nil when file.ContentFrom is nil

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[k8s-ci-robot]

Hi @chymy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

Seems to depend on if we want to support creating empty files. I'm not sure about that.

/ok-to-test

[chymy]

Seems to depend on if we want to support creating empty files. I'm not sure about that.

After testing, it supports creating empty files. Maybe some users just want to create empty files.

[chymy]

/retest

[sbueringer]

Seems to depend on if we want to support creating empty files. I'm not sure about that.

After testing, it supports creating empty files. Maybe some users just want to create empty files.

Yup, right now it works, because we don't block it. It's fine for me to keep that behavior as is.

I'm just not sure what our intention was when we added the error constant initially, because it seems to indicate that we had different plans then. But I think someone else can provide more context.

[chymy]

/test pull-cluster-api-apidiff-main

[k8s-ci-robot]

@chymy: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-cluster-api-apidiff-main	c849885	link	/test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[chymy]

@alexeldeib What about you?

[CecileRobertMichon]

From what I can remember, I think MissingFileSourceMsg is meant to be used if ContentFrom is not nil, indicating the user wants to fill the file from a source, but no source was specified. This would become relevant if we ever add more file source options besides Secret as noted in https://github.com/kubernetes-sigs/cluster-api/pull/4606/files#diff-466d019b7ec6acc1f196f24df198cb9d8d0e20602ffb0e2b7cba026cf65fdac6L79.

Right now the var is unused because only secrets are supported so we can directly check that the secret name & key are set. I think it's okay to remove the unused var for now. If we ever add another FileSource type, we can re-add an error specific no file source being specified.

[CecileRobertMichon]

/lgtm

[fabriziopandini]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• bootstrap/kubeadm/OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment