Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Fix misspelling in some docs files #4551

Merged
merged 1 commit into from
Apr 30, 2021
Merged

📖 Fix misspelling in some docs files #4551

merged 1 commit into from
Apr 30, 2021

Conversation

chymy
Copy link
Contributor

@chymy chymy commented Apr 30, 2021

What this PR does / why we need it:
Fix misspelling in some docs files

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 30, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @chymy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 30, 2021
alexander-demicev
alexander-demicev approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 30, 2021
fabriziopandini
fabriziopandini reviewed Apr 30, 2021
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7ce39a0 into kubernetes-sigs:master Apr 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Apr 30, 2021
JoelSpeed
JoelSpeed reviewed Apr 30, 2021
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This merged while I was reviewing, left a couple of comment as I don't quite agree with all the changes here, WDYT @chymy

docs/proposals/20200511-clusterctl-extensible-template-processing.md
@@ -238,7 +238,7 @@ libraries so the issue of support should be solved with this contract.
a single yaml file. These artifacts will need to be “grouped” together to
support current retrieval mechanisms. Currently, `clusterctl config cluster`
retrieves templates from multiple sources such as ConfigMaps within a
cluster, URL, Github Repository, Local Repository and even the overrides
cluster, URL, Github Repository, Local Repository and even the overrides'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this apostrophe is required here, what's the motivation on this one? I think overrides directory forms one noun here rather than overrides owning the directory 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your reviews @JoelSpeed , you are right, I will revise it.

docs/proposals/20200602-machine-deletion-phase-hooks.md
@@ -109,7 +109,7 @@ lifecycle hook.
- Create a mechanism to signal what lifecycle point a machine is at currently.
- Dictate implementation of controllers that respond to the hooks.
- Implement ordering in the machine-controller.
- Require anyone use these hooks for normal machine operations, these are
- Require anyone uses these hooks for normal machine operations, these are
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in this context and format, use is preferred over uses. It think these bullets are imperative so that would make me lean towards use over uses anyway

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be Require anyone to use ..., this is require...to do something grammar

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Require anyone to use seems ok to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@alexander-demicev alexander-demicev alexander-demicev approved these changes

@randomvariable randomvariable Awaiting requested review from randomvariable

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
5 participants
@chymy @k8s-ci-robot @fabriziopandini @JoelSpeed @alexander-demicev