🐛 Add ability for nodeToMachines to filter by clusterName and namespace #4513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
enxebre
changed the title
|
lgtm |
vincepri
requested changes
Apr 22, 2021
enxebre
force-pushed
the
node-to-machine
branch
from
43d516e to
397dceb
Compare
k8s-ci-robot
added
size/L
enxebre
force-pushed
the
node-to-machine
branch
from
397dceb to
9745ea5
Compare
enxebre
force-pushed
the
node-to-machine
branch
from
9745ea5 to
4f96587
Compare
sbueringer
reviewed
May 11, 2021
| targetNode := &corev1.Node{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "node-1", | ||
| Namespace: ns.Name, |
There was a problem hiding this comment.
As Nodes are cluster-wide setting the Namespace doesn't make a lot of sense imho. Should we also prefix this again to make sure we don't clash with other tests?
sbueringer
reviewed
May 11, 2021
| }, timeout).Should(BeTrue()) | ||
|
|
||
| // Fake nodes for actual test of nodeToMachine. | ||
| FakeNodes := []*corev1.Node{ |
There was a problem hiding this comment.
Suggested change
| FakeNodes := []*corev1.Node{ | |
| fakeNodes := []*corev1.Node{ |
This is a best effort to filter machines by clusterName and namespace when reconciling from a node event.
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a best effort to filter machines by clusterName and namespace when reconciling from a node event.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3831