Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add healthprobe for bootstrap and controlplane #4460

Merged
merged 1 commit into from
Apr 13, 2021
Merged

✨ Add healthprobe for bootstrap and controlplane #4460

merged 1 commit into from
Apr 13, 2021

Conversation

chymy
Copy link
Contributor

@chymy chymy commented Apr 12, 2021

What this PR does / why we need it:
Add healthprobe for bootstrap provider and controlplane provider.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @chymy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 12, 2021
@fabriziopandini
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2021
@chymy chymy force-pushed the add-healthprobe branch from 84102cf to 43b9a57 Compare April 12, 2021 08:40
@fabriziopandini
Copy link
Member

/retest

@chymy
Copy link
Contributor Author

chymy commented Apr 12, 2021

/test pull-cluster-api-test-main

@sbueringer
Copy link
Member

@chymy I think we should also add probes to the manager.yamls

@chymy chymy force-pushed the add-healthprobe branch from 43b9a57 to cdefccd Compare April 13, 2021 02:23
@chymy
Copy link
Contributor Author

chymy commented Apr 13, 2021

/retest

@chymy
Copy link
Contributor Author

chymy commented Apr 13, 2021

/test pull-cluster-api-test-main

@chymy
Copy link
Contributor Author

chymy commented Apr 13, 2021

@chymy I think we should also add probes to the manager.yamls

Thanks @sbueringer, done.
Local testing is ok. I don't know why pull-cluster-api-test-main always fails.

@sbueringer
Copy link
Member

@chymy
Thx,
/lgtm

Looks unrelated to me. Unfortunately we have a lot of flaky tests right now. Hope we'll get that fixed soon.

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2021
@chymy
Copy link
Contributor Author

chymy commented Apr 13, 2021

/test pull-cluster-api-test-main

@JoelSpeed
Copy link
Contributor

Gave this a pass, no additions from me

/lgtm
/retest

@detiber
Copy link
Member

detiber commented Apr 13, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2021
@vincepri
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 026be8b into kubernetes-sigs:master Apr 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@sbueringer sbueringer

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
7 participants
@chymy @k8s-ci-robot @fabriziopandini @sbueringer @JoelSpeed @detiber @vincepri