Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 include deamonsets in list images in clusterctl #4455

Merged
merged 1 commit into from
Apr 13, 2021
Merged

🌱 include deamonsets in list images in clusterctl #4455

merged 1 commit into from
Apr 13, 2021

Conversation

ludusrusso
Copy link
Contributor

@ludusrusso ludusrusso commented Apr 9, 2021 •
edited
Loading

What this PR does / why we need it:
This PR adds deamonsets in list images in clusterctl.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4382

/cc @fabriziopandini

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 9, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @ludusrusso. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 9, 2021
@fabriziopandini
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2021
@ludusrusso ludusrusso force-pushed the issues/4382 branch 2 times, most recently from 3da05c0 to cead46d Compare April 12, 2021 11:08
@ludusrusso ludusrusso marked this pull request as ready for review April 12, 2021 19:53
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2021
davideimola
davideimola approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@davideimola davideimola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabriziopandini
Copy link
Member

@ludusrusso please squash commits, otherwise lgtm for me

@fabriziopandini
Copy link
Member

/lgtm

@ludusrusso
Copy link
Contributor Author

@ludusrusso please squash commits, otherwise lgtm for me

Done! Also rebased to master!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2021
vincepri
vincepri requested changes Apr 13, 2021
View reviewed changes
cmd/clusterctl/internal/util/objs.go Outdated Show resolved Hide resolved
cmd/clusterctl/internal/util/objs.go Outdated Show resolved Hide resolved
cmd/clusterctl/internal/util/objs.go Outdated Show resolved Hide resolved
cmd/clusterctl/internal/util/objs.go Outdated Show resolved Hide resolved
cmd/clusterctl/internal/util/objs.go Show resolved Hide resolved
cmd/clusterctl/internal/util/objs.go Outdated Show resolved Hide resolved
cmd/clusterctl/internal/util/objs.go Show resolved Hide resolved
cmd/clusterctl/internal/util/objs.go Outdated Show resolved Hide resolved
cmd/clusterctl/internal/util/objs.go Outdated Show resolved Hide resolved
cmd/clusterctl/internal/util/objs.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2021
@ludusrusso
Copy link
Contributor Author

@ludusrusso: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-test-main 8481b9f link /test pull-cluster-api-test-main
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

@vincepri did I broke something or it's the flaky test?

@ludusrusso
Copy link
Contributor Author

/retest

1 similar comment
@vincepri
Copy link
Member

/retest

@vincepri
Copy link
Member

/test pull-cluster-api-test-main

@vincepri
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2021
@fabriziopandini
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit 70cbb84 into kubernetes-sigs:master Apr 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Apr 13, 2021
@ludusrusso ludusrusso deleted the issues/4382 branch April 13, 2021 19:26
This was referenced Jun 25, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@vincepri vincepri vincepri requested changes

@enxebre enxebre enxebre left review comments

@davideimola davideimola davideimola approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@vincepri vincepri

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

clusterctl list images should include daemonsets
6 participants
@ludusrusso @k8s-ci-robot @fabriziopandini @vincepri @enxebre @davideimola