-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix KCP maxSurge field to be mutable #4438
🐛 Fix KCP maxSurge field to be mutable #4438
Conversation
Hi @jan-est. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
We probably also want to include the test case here as well. |
b4e4461
to
701339e
Compare
…n error during KCP upgrade after upgrading cluster from v0.3.x to v0.3.15. This PR is changing every field under spec.rolloutStrategy mutable.
701339e
to
ce5ab72
Compare
Would this patch be merged to next release v0.3.16? |
/lgtm
yes |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is fixing issue 4437. Webhook defaulting in v0.3.15 causing an error during KCP upgrade after upgrading cluster from v0.3.x to v0.3.15. This PR is changing every field under spec.rolloutStrategy mutable.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #