🌱 kcp: include node list error in KCP and control plane machine conditions

[sbueringer]

What this PR does / why we need it:

Not entirely sure that is what was intended by the issue.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4234

[mrajashree]

LGTM (👋 first time reviewer here)

[fabriziopandini]

I don't have strong opinions here, but I'm not sure that surfacing a plain client-go error could provide actionable informations to the users. however,
/lgtm

[sbueringer]

@fabriziopandini I'm fine with another solution or just closing the issue without a change. Just thought that was what issue #4234 wanted to change.

[detiber]

I don't have strong opinions here, but I'm not sure that surfacing a plain client-go error could provide actionable informations to the users.

I'm fine with another solution or just closing the issue without a change. Just thought that was what issue #4234 wanted to change.

I think it helps add some context to why the operation failed, but agree with @fabriziopandini that I'm not sure it provides actionable information for the user. I'm also not sure that we can provide actionable information for the user (since there are numerous reasons why we might not be able to list the nodes).

I'm a +1 on this change since it does provide additional information to the user, and we can always investigate ways to provide more actionable information down the road.

[CecileRobertMichon]

I think it helps add some context to why the operation failed

+1 from me

we can always iterate and make the error more actionable if we find a good way to do that.

Given the multiple +1s and lgtms
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment