-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 make manifest to use cert-manager.io/v1alpha2 #4411
🐛 make manifest to use cert-manager.io/v1alpha2 #4411
Conversation
I see this PR is targeting release-0.3, is the plan to keep |
given that it is required to use clusterctl v0.4.0 to create v1alpha4 clusters, it is fine to keep cert-manager.io/v1 in 0.4. |
/lgtm |
/approve |
Given that the other PR was marked as IIRC, clusterctl should check if there is a new version of the CLI available, is that not the case? I'd mostly like to understand if we need to keep full compatibility between the manifests going forward, I'm ok either way. |
I think we should aim to full compatibility between the manifests going forward (within a minor), and in this case this can be achieved with a small change. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it:
#4225 made clustectl to deploy cert manager v1.1.0. and updated manifests generation in order to generate Certificate objects using
cert-manager.io/v1
apiVersion.Unfortunately this is creating a problem for people using old versions of clusterctl for doing
clusterctl init
because e.g.:clusterctl init
with clusterctl v0.3.14 installs cert manager v0.16.1clusterctl init
then installs the latest version of providers, that now is v0.3.15 which createscert-manager.io/v1
objects.This makes init to fail with older version of clusterctl.
This PR fixes this problem by changing our manifests in order to generate Certificate objects using
cert-manager.io/v1alpha2
apiVersion, which can be processed either by v0.16.1 and v1.1.0 version of cert managerNote
As a temporary workaround it is possible to pin version of the installed providers