Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add E2E for scale in rollout #4347

Merged
merged 1 commit into from
Mar 30, 2021
Merged

✨ Add E2E for scale in rollout #4347

merged 1 commit into from
Mar 30, 2021

Conversation

jan-est
Copy link
Contributor

@jan-est jan-est commented Mar 22, 2021 •
edited
Loading

This PR implements E2E test for KCP scale in rollout.
Feature is added to master 4073 and will be part of the v1alpha4 release.
Related to issue 4282

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 22, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @jan-est. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 22, 2021
@fabriziopandini
Copy link
Member

/milestone v0.4.0
/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 22, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Mar 22, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 22, 2021
@jan-est jan-est mentioned this pull request Mar 25, 2021
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2021
@jan-est jan-est force-pushed the kcp-rollout-strategy-e2e-test branch from 276075c to 941d20f Compare March 26, 2021 07:18
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2021
@jan-est jan-est force-pushed the kcp-rollout-strategy-e2e-test branch from 941d20f to 4424d1b Compare March 26, 2021 07:22
fabriziopandini
fabriziopandini reviewed Mar 26, 2021
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm, waiting for a test run
/test pull-cluster-api-e2e-main-full

test/e2e/data/infrastructure-docker/v1alpha4/bases/cluster-with-kcp.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-make-main
  • /test pull-cluster-api-apidiff-main
  • /test pull-cluster-api-verify
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-e2e-full-main
  • /test pull-cluster-api-e2e-k8s-latest-main

Use /test all to run the following jobs:

  • pull-cluster-api-build-main
  • pull-cluster-api-make-main
  • pull-cluster-api-apidiff-main
  • pull-cluster-api-verify
  • pull-cluster-api-test-main
  • pull-cluster-api-e2e-main

In response to this:

sgtm, waiting for a test run
/test pull-cluster-api-e2e-main-full

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini
Copy link
Member

/test pull-cluster-api-e2e-full-main

1 similar comment
@fabriziopandini
Copy link
Member

/test pull-cluster-api-e2e-full-main

@jan-est jan-est force-pushed the kcp-rollout-strategy-e2e-test branch from 4424d1b to 8f1013e Compare March 28, 2021 15:16
@jan-est
Copy link
Contributor Author

jan-est commented Mar 28, 2021

/test pull-cluster-api-e2e-full-main

@jan-est
Copy link
Contributor Author

jan-est commented Mar 29, 2021

/retest

1 similar comment
@jan-est
Copy link
Contributor Author

jan-est commented Mar 29, 2021

/retest

@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2021
@sbueringer
Copy link
Member

/lgtm

@fabriziopandini
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit ad10911 into kubernetes-sigs:master Mar 30, 2021
@furkatgofurov7 furkatgofurov7 mentioned this pull request Apr 21, 2021
Closed
@sedefsavas sedefsavas mentioned this pull request May 26, 2021
Closed
@sedefsavas sedefsavas mentioned this pull request Jun 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@jan-est @k8s-ci-robot @fabriziopandini @sbueringer