-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 docs: Add installation guide with homebrew #4345
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @ludusrusso! |
Hi @ludusrusso. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What about to add a chapter on updating clusterctl with brew? |
/check-cla |
/ok-to-test
This is a good idea, but IMO this should not go in the quick start. what about having something under tasks? Also, If I'm not wrong, we are also still discussing how to get automatic upgrades of the formula... |
I agree with @fabriziopandini! I'll also put this in WIP until we decide the best name for the homebrew formula! |
/milestone v0.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should get rid of the macOS curl instructions. Though no harm really having both options explained.
Looks good to me, but one small typo pointed out.
@stmcginnis thanks for help! |
Brew use on Linux still seems relatively low, but I could see it being useful. Just another thought, but we could have a separate |
+1 on having a brew tab as an alternative method. /ok-to-test |
@vincepri @stmcginnis what do you think? |
Love it! |
I think we are ready on this! |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Add installation guide with homebrew for macOS in book. Related to #2389
Can be merged once Homebrew/homebrew-core/73610 is merged!