Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Add information on using kustomize with CAPI #4333

Merged
merged 1 commit into from
Apr 13, 2021
Merged

📖 Add information on using kustomize with CAPI #4333

merged 1 commit into from
Apr 13, 2021

Conversation

scottslowe
Copy link
Contributor

What this PR does / why we need it:
This PR adds documentation on using kustomize with Cluster API to provide additional flexibility beyond what clusterctl config cluster currently provides.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3373

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 16, 2021
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 16, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @scottslowe. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 16, 2021
@fabriziopandini
Copy link
Member

/ok-to-test
/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Mar 18, 2021
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 18, 2021
fabriziopandini
fabriziopandini reviewed Mar 22, 2021
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scottslowe
few small suggestion to make it easier to understand the filesystem setup you are envisioning, but overall it looks great!

docs/book/src/tasks/using-kustomize.md Outdated Show resolved Hide resolved
docs/book/src/tasks/using-kustomize.md Outdated Show resolved Hide resolved
docs/book/src/tasks/using-kustomize.md Outdated Show resolved Hide resolved
@fabriziopandini
Copy link
Member

/test pull-cluster-api-test-main
great work! ready to lgtm after squash

@scottslowe
Add information on using kustomize with CAPI
28f70b4 
Add examples of using kustomize with CAPI (add MHC, change machine image, use namePrefix/nameSuffix). Include information on modifying kustomize transformer configuration.

Signed-off-by: Scott Lowe <[email protected]>
@scottslowe
Copy link
Contributor Author

@fabriziopandini Commits squashed, let me know if anything else is needed!

@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2021
CecileRobertMichon
CecileRobertMichon reviewed Apr 13, 2021
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

thanks @scottslowe !

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2deb9de into kubernetes-sigs:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@moshloop moshloop Awaiting requested review from moshloop

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

[book] Add advanced section to document using kustomize + yaml templates
4 participants
@scottslowe @k8s-ci-robot @fabriziopandini @CecileRobertMichon