Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Include machinepools in descendant count #4299

Conversation

jimmidyson
Copy link
Member

What this PR does / why we need it:

Backport of #4295 to release-0.3 branch.

Without this, machinepool descendants are ignored in deletion logic and can be orphaned and unable to delete without manually deleting the finalizer.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 11, 2021
Without this, machinepool descendants are ignored in deletion logic and
can be orphaned and unable to delete without manually deleting the
finalizer.
@jimmidyson jimmidyson force-pushed the machine-pool-descendants-backport branch from ff760dc to b709bee Compare March 11, 2021 21:39
@CecileRobertMichon CecileRobertMichon added this to the v0.3.x milestone Mar 11, 2021
@CecileRobertMichon
Copy link
Contributor

/lgtm
/assign @vincepri

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2021
@fabriziopandini
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0ed4c91 into kubernetes-sigs:release-0.3 Mar 12, 2021
@jimmidyson jimmidyson deleted the machine-pool-descendants-backport branch March 12, 2021 11:39
@jimmidyson
Copy link
Member Author

@CecileRobertMichon @fabriziopandini do you think we could get a new 0.3 release including this fix?

@fabriziopandini
Copy link
Member

AFAIK there is not yet a defined date for the next patch release.
Let's discuss this the next office hours

@vincepri
Copy link
Member

0.3.16 should be out by end of month, that's been our cadence so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants