-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Default Kubelet cgroupDriver to systemd for Kubernetes >= 1.21 #4294
⚠️ Default Kubelet cgroupDriver to systemd for Kubernetes >= 1.21 #4294
Conversation
technically, the CAPI change is not needed as long as maybe this code path is done during upgrade, where an old config map has to be migrated to match the image builder driver? |
this is the case WRT to the minor fix, given this is a backport I prefer keep things consistent; eventually we can fix in main and backport those nits well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/assign @neolit123
for lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest |
What this PR does / why we need it:
back port of #4236
For Kubernetes >= 1.21, image builder is going to setup containerd for using systemd cgroup.
KCP should take care of adapting the Kubelet-Config map to be consistent with this change.
Which issue(s) this PR fixes:
Rif #4099
/area control-plane
/milestone v0.3.x