Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Updates conversion error message with reasoning #4267

Merged
merged 1 commit into from
Mar 8, 2021
Merged

🌱 Updates conversion error message with reasoning #4267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion util/conversion/conversion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ func ConvertReferenceAPIContract(ctx context.Context, c client.Client, restConfi
// If there is no label, return early without changing the reference.
supportedVersions, ok := metadata.Labels[contract]
if !ok || supportedVersions == "" {
return errors.Errorf("cannot find any versions matching contract %q for CRD %v", contract, metadata.Name)
return errors.Errorf("cannot find any versions matching contract %q for CRD %v as contract version label(s) are either missing or empty", contract, metadata.Name)
}

// Pick the latest version in the slice and validate it.
Expand Down