Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reviewers for CAPI operator #4260

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Add reviewers for CAPI operator #4260

merged 1 commit into from
Mar 9, 2021

Conversation

MarcelMue
Copy link
Contributor

What this PR does / why we need it:

We discussed this several times and it should take some burden of the main reviewers. Approvers stay the same.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 5, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @MarcelMue. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 5, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Mar 5, 2021
MarcelMue
MarcelMue commented Mar 5, 2021
View reviewed changes
OWNERS_ALIASES
# OWNER_ALIASES for exp/operator
# -----------------------------------------------------------

cluster-api-operator-reviewers:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-demichev Do you know who else should be a reviewer?

@MarcelMue
Copy link
Contributor Author

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes-sigs org. You can then trigger verification by writing /verify-owners in a comment.

* alexander-demichev
  
  * User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

Okay we need to sort this out then.

fabriziopandini
fabriziopandini reviewed Mar 5, 2021
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are going to merge this branch back on main, I think we should add an owner file in the operator folder (instead of modifying the reviewer list in the root owner file)
see e.g. https://github.com/kubernetes-sigs/cluster-api/blob/master/cmd/clusterctl/OWNERS

@fabriziopandini
Copy link
Member

/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Mar 5, 2021
CecileRobertMichon
CecileRobertMichon reviewed Mar 5, 2021
View reviewed changes
OWNERS Outdated
@@ -17,5 +17,4 @@ emeritus_maintainers:
- ncdc

reviewers:
- cluster-api-maintainers
- cluster-api-reviewers
- cluster-api-operator-reviewers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about creating a separate OWNERS file in exp/operator so it's scoped to only the operator files?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see Fabrizio already the same thing commented above #4260 (review)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL. Does this make more sense? I tried to read the docs beforehand but am not too familiar with the OWNER structure.

@MarcelMue MarcelMue force-pushed the add-operator-reviewers branch from 1e720bb to e63919b Compare March 5, 2021 21:44
fabriziopandini
fabriziopandini reviewed Mar 8, 2021
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM for me, waiting for K8s-sigs memberships

@MarcelMue
Copy link
Contributor Author

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Mar 9, 2021
@MarcelMue
Copy link
Contributor Author

Memberships are in - PTAL 🚀

@JoelSpeed
Copy link
Contributor

/lgtm

Thanks @MarcelMue

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2021
@fabriziopandini
Copy link
Member

/lgtm

@CecileRobertMichon
Copy link
Contributor

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 64addc3 into kubernetes-sigs:operator-0.4 Mar 9, 2021
@MarcelMue MarcelMue deleted the add-operator-reviewers branch March 9, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-demicev alexander-demicev alexander-demicev left review comments

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@fabriziopandini fabriziopandini

@CecileRobertMichon CecileRobertMichon

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
6 participants
@MarcelMue @k8s-ci-robot @fabriziopandini @JoelSpeed @CecileRobertMichon @alexander-demicev