Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix KCP remediation when node Name & etcd member Name != machine Name #4242

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR fixes a problem in KCP remediation not properly computing the targetCluster when node Name & etcd member Name != machine Name (e.g. AWS)

Backport of #4240

Which issue(s) this PR fixes:
Fixes #4239

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 2, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 2, 2021
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-verify 44d737e link /test pull-cluster-api-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vincepri
Copy link
Member

vincepri commented Mar 2, 2021

/retest

@fabriziopandini fabriziopandini force-pushed the fix-kcp-remediation-when-nodeName!=machineName-0.3b branch from 44d737e to e25ec2c Compare March 2, 2021 22:14
@fabriziopandini
Copy link
Member Author

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Mar 2, 2021
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vincepri
Copy link
Member

vincepri commented Mar 2, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2021
@vincepri
Copy link
Member

vincepri commented Mar 2, 2021

This should be merged soon 👍

@k8s-ci-robot k8s-ci-robot merged commit 681073d into kubernetes-sigs:release-0.3 Mar 2, 2021
@fabriziopandini fabriziopandini deleted the fix-kcp-remediation-when-nodeName!=machineName-0.3b branch March 3, 2021 09:51
@fabriziopandini
Copy link
Member Author

/milestone v0.3.x

@k8s-ci-robot k8s-ci-robot added this to the v0.3.x milestone Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants