-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Stop gap for kubeadm types removal #4227
🌱 Stop gap for kubeadm types removal #4227
Conversation
We should keep those exported functions, and Add a new |
3fc5e40
to
756e1eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, otherwise lgtm
I don't think this change requires the proposal to be merged? |
756e1eb
to
805b781
Compare
As much test cycles we can get, the better! |
805b781
to
3715ef4
Compare
/hold cancel |
@CecileRobertMichon @detiber any objection to get this work moving so we can get as much a possible test cycles on this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @CecileRobertMichon
for final approval
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel sorry completely missed the ping on this |
What this PR does / why we need it:
This PR implements a stop-gap solution for kubeadm types removal explicitly designed for back-porting on the v1alpha3 branch.
The solution implemented is described in the #4170 (and more specifically this is alternative 2 for v1alpha3).
After this will be backported, a proper conversion mechanism is going to be implemented in v1alpha4 only (also described in the proposal).
Which issue(s) this PR fixes:
Fixes #
/milestone v0.4.0
/hold
For the CAEP to merge
@vincepri