🌱 Enable ClusterResourceSet by default

[vincepri]

Signed-off-by: Vince Prignano [email protected]

What this PR does / why we need it:

Graduate CRS in v0.4.0 by enabling the functionality by default.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3311

/milestone v0.4.0
/assign @CecileRobertMichon @sedefsavas

[sedefsavas]

Kubernetes features are enabled by default when the features become beta.
should we consider upgrading CRS to beta? And even machinepools?

[CecileRobertMichon]

We should move CRS out of exp/ before enabling it by default.

For MachinePool we're not quite ready because of #3424 and #4063

[vincepri]

Kubernetes features are enabled by default when the features become beta.

This is true, we can switch it to a beta experiment. I think we've had enough soak time so far.

We should move CRS out of exp/ before enabling it by default.

Following upstream Kubernetes feature gate model, like Sedef mentioned, there are a bunch of features that are enabled as part of an experiment that are either alpha or beta. Or are we saying that we want only alpha features in exp/?

[CecileRobertMichon]

following the k8s model and moving it to beta in exp SGTM

[fabriziopandini]

+1 to graduate CRS to beta
For consistency, we should upgrade also manifests, e.g.

cluster-api/config/manager/manager.yaml

Line 25 in 280db9a

- "--feature-gates=MachinePool=${EXP_MACHINE_POOL:=false},ClusterResourceSet=${EXP_CLUSTER_RESOURCE_SET:=false}"

And documentation about experimental features
https://master.cluster-api.sigs.k8s.io/tasks/experimental-features/experimental-features.html

Might be there is also some other place like e.g. tests config files...

[vincepri]

This is ready to go

[sedefsavas]

/lgtm

[vincepri]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment