🌱 clusterctl v1alpha4 should not install v1alpha3 providers #4200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
fabriziopandini
force-pushed
the
clusterctl-v1alpha4-should-not-install-v1alpha3-providers
branch
2 times, most recently
from
c62b77b to
a281f28
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/milestone v0.4.0 |
|
/retest |
1 similar comment
|
/retest |
|
/retitle 🌱 clusterctl v1alpha4 should not install v1alpha3 providers |
k8s-ci-robot
changed the title
k8s-ci-robot
added
lgtm
|
/lgtm cancel @fabriziopandini squash commits please |
k8s-ci-robot
removed
the
lgtm
fabriziopandini
force-pushed
the
clusterctl-v1alpha4-should-not-install-v1alpha3-providers
branch
from
3629aea to
3e572ed
Compare
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
|
/test pull-cluster-api-test-main |
1 similar comment
|
/test pull-cluster-api-test-main |
fabriziopandini
deleted the
clusterctl-v1alpha4-should-not-install-v1alpha3-providers
branch
This was referenced Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Cluster API v1alpha4 is introducing changes in how providers are deployed (see e.g webhooks running with manager).
As a consequence, clusterctl version v1alpha4 should not be allowed to install v1alpha3 providers
NB: While doing the change, also clusterctl version v1alpha4 should not be allowed to install v1alpha5 providers was implemented, and tests are now refactored in order to make changes for supporting the next contract less invasive.
This will also ensure easier backport
Which issue(s) this PR fixes:
Rif #4191