Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Remove verbose flag from make test #4187

Merged
merged 1 commit into from
Feb 22, 2021
Merged

🌱 Remove verbose flag from make test #4187

merged 1 commit into from
Feb 22, 2021

Conversation

MarcelMue
Copy link
Contributor

What this PR does / why we need it:

make test now has very concise output when run in local development, making it easier to spot actual failures. There is an additional target called make test-verbose which is used in CI to continue to have the full verbose output.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4182

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 12, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @MarcelMue. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2021
MarcelMue
MarcelMue commented Feb 12, 2021
View reviewed changes
Makefile Show resolved Hide resolved
Makefile
source ./scripts/fetch_ext_bins.sh; fetch_tools; setup_envs; go test -v ./... $(TEST_ARGS)

.PHONY: test-cover
test-cover: ## Run tests with code coverage and code generate reports
source ./scripts/fetch_ext_bins.sh; fetch_tools; setup_envs; go test -v -coverprofile=out/coverage.out ./... $(TEST_ARGS)
test-cover: ## Run tests with code coverage and code generate reports.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments are all inconsistent in this file. Some are sentences, some have . some have neither. I didn't make it consistent here because I didn't want to expand this PR too much.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a nice follow up/good-first issue...

invidian
invidian approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@vincepri
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 12, 2021
@MarcelMue
Copy link
Contributor Author

/retest

fabriziopandini
fabriziopandini reviewed Feb 15, 2021
View reviewed changes
Makefile Show resolved Hide resolved
test/infrastructure/docker/Makefile Show resolved Hide resolved
vincepri
vincepri reviewed Feb 17, 2021
View reviewed changes
Makefile Outdated
test-cover: ## Run tests with code coverage and code generate reports
source ./scripts/fetch_ext_bins.sh; fetch_tools; setup_envs; go test -v -coverprofile=out/coverage.out ./... $(TEST_ARGS)
test-cover: ## Run tests with code coverage and code generate reports.
source ./scripts/fetch_ext_bins.sh; fetch_tools; setup_envs; go test -coverprofile=out/coverage.out ./... $(TEST_ARGS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
source ./scripts/fetch_ext_bins.sh; fetch_tools; setup_envs; go test -coverprofile=out/coverage.out ./... $(TEST_ARGS)
TEST_ARGS="$(TEST_ARGS) -coverprofile=out/coverage.out" $(MAKE) test

Something like that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works 👍

@MarcelMue
Copy link
Contributor Author

PTAL - I think this now covers most of the concerns :)

vincepri
vincepri reviewed Feb 19, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
fabriziopandini
fabriziopandini reviewed Feb 22, 2021
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nit, then lgtm for me

test/infrastructure/docker/Makefile Outdated Show resolved Hide resolved
@MarcelMue
Copy link
Contributor Author

/retest

1 similar comment
@MarcelMue
Copy link
Contributor Author

/retest

@MarcelMue
Copy link
Contributor Author

Okay - finally all green 🚀

@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2021
vincepri
vincepri approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Feb 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit 013aa99 into kubernetes-sigs:master Feb 22, 2021
@invidian invidian mentioned this pull request Mar 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invidian invidian invidian approved these changes

@fabriziopandini fabriziopandini fabriziopandini left review comments

@vincepri vincepri vincepri approved these changes

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

Consider not using -v when running tests
5 participants
@MarcelMue @k8s-ci-robot @vincepri @fabriziopandini @invidian