🌱 Include metadata for the CAPI releases #4167
Conversation
k8s-ci-robot
added
cncf-cla: yes
| releaseSeries: | ||
| - major: 0 | ||
| minor: 4 | ||
| contract: v1alpha4 | ||
| - major: 0 | ||
| minor: 3 | ||
| contract: v1alpha3 |
There was a problem hiding this comment.
I specifically excluded v1alpha2 because the bootstrap provider was v0.1.x for v1alpha2 and ControlPlane provider didn't exist.
Question: Do we need to include v1alpha3 series here?
There was a problem hiding this comment.
I think we should for future reference, even if it's not strictly needed. Are there any downsides to including it?
There was a problem hiding this comment.
So the only downside I can see is that, currently the three providers - CoreProvider/cluster-api, BootstrapProvider/Kubeadm, and ControlPlaneProvider/Kubeadm all share the same repository and therefore the same metadata.yaml.
If we include a series for v1alpha2 such as
- major: 0
minor: 2
contract: v1alpha2
it would be misleading because for BootstrapProvider/Kubeadm it was v0.1 for v1alpha2. See here for old reference.
However, the above would be accurate for ControlPlaneProvider/Kubeadm. So because of BootstrapProvider/Kubeadm, I decided to not include it.
|
@wfernandes does this change require any action from providers? |
|
@CecileRobertMichon Nope. There shouldn't be any changes to other providers. |
wfernandes
force-pushed
the
core-provider-metadata
branch
from
234038c to
b40f31f
Compare
k8s-ci-robot
added
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
Since we removed the embedded metadata, we are going to include the metadata.yaml in the CAPI release assets.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #4156