Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove verbose log line from CRS controller #4150

Merged

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented Feb 8, 2021

This log line was logged every time the function ApplyClusterResourceSet
was called. This function is called every time CRS reconciles, even if
it doesn't have any more work to do, causing a lot of similar error
lines to be printed to users.

This change removes the log line for quieter logs.

Signed-off-by: Vince Prignano [email protected]

This log line was logged every time the function ApplyClusterResourceSet
was called. This function is called every time CRS reconciles, even if
it doesn't have any more work to do, causing a lot of similar error
lines to be printed to users.

This change removes the log line for quieter logs.

Signed-off-by: Vince Prignano <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 8, 2021
@vincepri
Copy link
Member Author

vincepri commented Feb 8, 2021

/milestone v0.3.x

@k8s-ci-robot k8s-ci-robot added this to the v0.3.x milestone Feb 8, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 8, 2021
@vincepri
Copy link
Member Author

vincepri commented Feb 8, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2021
@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 94574b2 into kubernetes-sigs:release-0.3 Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants