Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Enable Webhooks and CertManager for CAPI operator #4132

Conversation

wfernandes
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4131
Ref #3833

/area api
/area operator

@k8s-ci-robot
Copy link
Contributor

@wfernandes: The label(s) area/operator cannot be applied, because the repository doesn't have them

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4131
Ref #3833

/area api
/area operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the area/api Issues or PRs related to the APIs label Jan 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign neolit123 after the PR has been reviewed.
You can assign the PR to them by writing /assign @neolit123 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 29, 2021
@wfernandes
Copy link
Contributor Author

/hold
Putting a hold because ideally, this PR will be merged after #4126

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2021
Warren Fernandes added 21 commits January 29, 2021 09:25
Domain is cluster.x-k8s.io
kubebuilder create api --group operator --version v1alpha4 --kind CoreProvider
kubebuilder create api --group operator --version v1alpha4 --kind BootstrapProvider
Created Resources, not controllers
kubebuilder create api --group operator --version v1alpha4 --kind ControlPlaneProvider
Created Resources, not controllers
kubebuilder create api --group operator --version v1alpha4 --kind InfrastructureProvider
Created Resources, not controllers
Fix some module imports. Will be cleaned up in future PRs.
Removes the ginkgo BeforeSuite pattern
@wfernandes wfernandes force-pushed the capi-operator-webhook-certmanager branch 2 times, most recently from e5690a1 to 4b98eee Compare February 1, 2021 16:29
Adds CRDs to providers category
@wfernandes wfernandes force-pushed the capi-operator-webhook-certmanager branch from 4b98eee to da91042 Compare February 1, 2021 17:05
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2021
@k8s-ci-robot
Copy link
Contributor

@wfernandes: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wfernandes wfernandes marked this pull request as draft February 9, 2021 22:50
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2021
@wfernandes wfernandes changed the base branch from master to operator-0.4 February 23, 2021 18:22
@wfernandes wfernandes marked this pull request as ready for review March 4, 2021 01:47
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2021
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 4, 2021
@fabriziopandini
Copy link
Member

/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Mar 5, 2021
@fabriziopandini
Copy link
Member

@JoelSpeed @alexander-demichev do we still need this PR?

@alexander-demicev
Copy link
Contributor

I think it can be closed, rebasing it will be harder than opening a new one.

@fabriziopandini
Copy link
Member

as per comment above
/close

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: Closed this PR.

In response to this:

as per comment above
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wfernandes wfernandes deleted the capi-operator-webhook-certmanager branch May 26, 2021 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Issues or PRs related to the APIs cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable webhooks and cert-manager for CAPI operator
4 participants