🐛Fix ClusterResourceSet not getting Secret/Configmap TypeMeta #4129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
sedefsavas
changed the title
sedefsavas
force-pushed
the
crs-live-client
branch
from
bcc2137 to
3341e0f
Compare
|
@sedefsavas Can you open a PR to the main branch first? |
k8s-ci-robot
added
size/XXL
sedefsavas
force-pushed
the
crs-live-client
branch
from
3341e0f to
306801e
Compare
k8s-ci-robot
added
size/S
sedefsavas
force-pushed
the
crs-live-client
branch
from
306801e to
1c85ffb
Compare
|
/retest |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
sedefsavas
force-pushed
the
crs-live-client
branch
from
1c85ffb to
982bd07
Compare
|
/hold cancel |
k8s-ci-robot
added
size/M
|
Moved PR to the main branch. |
wfernandes
reviewed
Feb 1, 2021
sedefsavas
force-pushed
the
crs-live-client
branch
from
982bd07 to
f1cdf7b
Compare
|
/test pull-cluster-api-test-main |
|
@sedefsavas Is the test failure related? It seems to be failing on CRS tests |
vincepri
reviewed
Feb 3, 2021
Comment on lines
+392
to
393
| err := r.Client.Scheme().Convert(resourceInterface, raw, nil) | ||
| if err != nil { |
There was a problem hiding this comment.
Suggested change
| err := r.Client.Scheme().Convert(resourceInterface, raw, nil) | |
| if err != nil { | |
| if err := r.Client.Scheme().Convert(resourceInterface, raw, nil); err != nil { |
|
Passing locally and controllers test failed there. /test pull-cluster-api-test-main |
|
It passed now, retesting. |
|
This is looking good. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
|
/milestone v0.4.0 @sedefsavas Can you open a cherry-pick PR to release-0.3 once this merges? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
After using live client for ConfigMap and Secrets, when doing get on the resources,
TypeMetais returned nil.Using a different conversion fills
apiVersionandkindfields.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #4115