⚠️ Updates controller-runtime version to v0.8.1 #4109
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
srm09
force-pushed
the
update-controller-runtime-version
branch
from
21eff81 to
1ab40d2
Compare
|
This is a |
|
/retitle |
k8s-ci-robot
changed the title
|
@vincepri Any suggestions? |
There was a problem hiding this comment.
/lgtm
/hold
@CecileRobertMichon @detiber FYI please review, there are required changes to the slice types to use non-pointer structs
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
Shall we add this requirement to |
This involved bumping the code-gen version to 0.20 because the signature of the function had been updated. Required regenerating the conversion code. Also updated the types containing slice of pointers of custom object types to slice of custom objects to avoid conversion errors. Update the v1a3 -> v1a4 upgrade docs to record this requirement. Signed-off-by: Sagar Muchhal <[email protected]>
srm09
force-pushed
the
update-controller-runtime-version
branch
from
1ab40d2 to
1356c4a
Compare
k8s-ci-robot
removed
the
lgtm
|
/test pull-cluster-api-test-main |
|
@CecileRobertMichon @detiber Did y'all get a chance to take a look at this one? |
There was a problem hiding this comment.
/lgtm
note to self: we'll have to change the Subnets type in CAPZ https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/master/api/v1alpha3/types.go#L96
k8s-ci-robot
added
lgtm
|
/hold cancel |
The changes to the slice types seem like they are a concerning issue since it seems to effect not just the v1alpha4 types but also the v1alpha3 types. It seems like this is a bug that we need to get addressed in the code generator. |
|
@detiber Are you thinking about folks importing and using v1alpha3 type while using a v0.4.x version? |
No, my concern was around how it would potentially affect existing resources that are already defined, would this break us being able to deserialize previously stored resources in etcd? I don't see any changes to the CRD openapi definition, so maybe that is the case. If I'm reading the apiextensions-apiserver registry code right, it looks like the resource is stored in etcd as Unstructured, so I suppose as long as there isn't any impact on serialization between yaml/json and golang structs or between unstructured.Unstructured and the golang structs then it's likely a non-issue. After digging through things, it looks like it's a non-issue, the type change to the v1alpha3 resource caught me a bit off guard :) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
This patch updates the controller-runtime version to
v0.8.1. The k8s dependencies in the codebase have been updated to v0.20.2 since this version of controller-runtime has those dependencies.Which issue(s) this PR fixes:
Fixes #4096