Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Migrate gcr.io/kubernetes-ci-images to gcr.io/k8s-staging-ci-images #4107

Merged
merged 1 commit into from
Feb 4, 2021
Merged

🌱 Migrate gcr.io/kubernetes-ci-images to gcr.io/k8s-staging-ci-images #4107

merged 1 commit into from
Feb 4, 2021

Conversation

fmuyassarov
Copy link
Member

What this PR does / why we need it:
Migrate gcr.io/kubernetes-ci-images to gcr.io/k8s-ci-images

Which issue(s) this PR fixes:
Fixes #4103

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @fmuyassarov. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 22, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 22, 2021
@fmuyassarov
Copy link
Member Author

/cc @fabriziopandini

@vincepri
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 22, 2021
@fmuyassarov
Copy link
Member Author

/retest

@fmuyassarov
Copy link
Member Author

@vincepri Do I have to re-generate bindata to pass verify?

@fabriziopandini
Copy link
Member

Do I have to re-generate bindata to pass verify?

yes, because this PR is changing a script that is embedded as bin data

@fmuyassarov fmuyassarov force-pushed the capi-issue-4103/feruz branch 2 times, most recently from 95654db to 2441437 Compare January 25, 2021 09:48
@fmuyassarov
Copy link
Member Author

Do I have to re-generate bindata to pass verify?

yes, because this PR is changing a script that is embedded as bin data

Thank you. Done.

@fmuyassarov
Copy link
Member Author

/retest

@vincepri
Copy link
Member

@furkatgofurov7 make generate should run all generation targets

@fmuyassarov fmuyassarov force-pushed the capi-issue-4103/feruz branch from 2441437 to c34e2d1 Compare January 25, 2021 17:00
@fmuyassarov
Copy link
Member Author

@vincepri this should be good to go I think.

@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2021
@randomvariable
Copy link
Member

/lgtm

@sedefsavas
Copy link

Should we also change this to /k8s-release-dev here?

cluster-api/test/framework/kubernetesversions/data/debian_injection_script.envsubst.sh

Line 84 in a597f9e

CI_URL="gs://kubernetes-release-dev/ci/$${KUBERNETES_VERSION}-bazel/bin/linux/amd64"

@fmuyassarov
Copy link
Member Author

Should we also change this to /k8s-release-dev here?

cluster-api/test/framework/kubernetesversions/data/debian_injection_script.envsubst.sh

Line 84 in a597f9e

CI_URL="gs://kubernetes-release-dev/ci/$${KUBERNETES_VERSION}-bazel/bin/linux/amd64"

Yes, initially we tried to migrate https://storage.googleapis.com/kubernetes-release-dev to https://storage.googleapis.com/k8s-release-dev but then as @neolit123 commented in #4103 (comment) the latest artifacts weren't available in GCS bucket.

@neolit123
Copy link
Member

Yes, initially we tried to migrate https://storage.googleapis.com/kubernetes-release-dev to https://storage.googleapis.com/k8s-release-dev but then as @neolit123 commented in #4103 (comment) the latest artifacts weren't available in GCS bucket.

the CI job that is responsible for pushing artifacts to the new GCS is failing:
kubernetes/test-infra#20586 (comment)
kubernetes/kubeadm#2380 (comment)

@randomvariable
Copy link
Member

Is that problem fixed now? If so, we should change over now I think.

@neolit123
Copy link
Member

the GCS problem is fixed, but we found a problem with the ci/latest marker and the GCR:
https://kubernetes.slack.com/archives/C09QZ4DQB/p1612269558032700

@neolit123
Copy link
Member

potential fix for the new GCR problem:
kubernetes/test-infra#20712

@justaugustus
Copy link
Member

/retitle 🌱 Migrate gcr.io/kubernetes-ci-images to gcr.io/k8s-staging-ci-images

@k8s-ci-robot k8s-ci-robot changed the title 🌱 Migrate gcr.io/kubernetes-ci-images to gcr.io/k8s-ci-images 🌱 Migrate gcr.io/kubernetes-ci-images to gcr.io/k8s-staging-ci-images Feb 2, 2021
vincepri
vincepri approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neolit123 @justaugustus Seems the linked PR in test-infra has been merged, please feel free to unhold if we're ready to merge

/approve
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2021
@CecileRobertMichon
Copy link
Contributor

who is going to own backporting this to v1alpha3?

@fmuyassarov
Copy link
Member Author

who is going to own backporting this to v1alpha3?

I am happy to do it @CecileRobertMichon .

@fmuyassarov fmuyassarov mentioned this pull request Feb 3, 2021
Merged
@neolit123
Copy link
Member

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2021
@fmuyassarov
Copy link
Member Author

who is going to own backporting this to v1alpha3?

I am happy to do it @CecileRobertMichon .

Here is the backport to release-0.3 branch: #4143

@fmuyassarov
Copy link
Member Author

/retest

@vincepri
Copy link
Member

vincepri commented Feb 4, 2021

/test pull-cluster-api-test-main

@k8s-ci-robot k8s-ci-robot merged commit da2fab9 into kubernetes-sigs:master Feb 4, 2021
@CecileRobertMichon CecileRobertMichon mentioned this pull request Jul 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@neolit123 neolit123

@randomvariable randomvariable

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate usage of "gcr.io/kubernetes-ci-images"
9 participants
@fmuyassarov @k8s-ci-robot @vincepri @fabriziopandini @randomvariable @sedefsavas @neolit123 @justaugustus @CecileRobertMichon