🐛 Set error_exit code arg in kubeadm bootstrap script #4079
Conversation
k8s-ci-robot
added
cncf-cla: yes
| @@ -102,7 +102,7 @@ function retry-command() { | |||
| sleep 15 | |||
| done | |||
| if [ ${kubeadm_return} -ne 0 ]; then | |||
| log::error_exit "too many errors, exiting" | |||
| log::error_exit "too many errors, exiting" "${kubeadm_return}" | |||
There was a problem hiding this comment.
not sure if we want to set a different exit code or pass through the kubeadm_return
/cc @randomvariable
There was a problem hiding this comment.
I think pass through is fine.
|
/hold need to run make generate |
k8s-ci-robot
added
the
do-not-merge/hold
CecileRobertMichon
force-pushed
the
kubeadm-script-code
branch
from
6f36be4 to
b3edcfe
Compare
k8s-ci-robot
added
size/S
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
lgtm for me, but I leave the final word to @randomvariable |
|
/milestone v0.4.0 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thanks for this. I had seen that line crop up before, but didn't know what it was. /lgtm |
k8s-ci-robot
added
the
lgtm
What this PR does / why we need it: The error_exit func expects a message (
$1) and code ($2) arg, but some places in the script set a message arg, resulting in this error when an error occurs:Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #