🌱 Add optional parameter for using repolist to the kubetest library #4069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
I have this working with kubernetes-sigs/cluster-api-provider-azure#1119 |
jsturtevant
changed the title
jsturtevant
changed the title
jsturtevant
force-pushed
the
add-kubetestrepolist
branch
2 times, most recently
from
7ff8792 to
f5696e9
Compare
|
/test pull-cluster-api-test-main |
jsturtevant
force-pushed
the
add-kubetestrepolist
branch
from
f5696e9 to
03d92d1
Compare
|
The tests failing was related to #4076, I've rebased to include that change |
|
I guess the timeout didn't help, When I run this the failing test locally I get a pass: |
|
/milestone v0.4.0 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds an optional parameter for using
KUBE_TEST_REPO_LIST. More info on thisKUBE_TEST_REPO_LISTis here: https://github.com/kubernetes/kubernetes/blob/master/test/images/README.md#testing-the-new-imageThis currently required to be able to run the upstream tests for windows: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/windows/README.md#notes-to-run-sig-windows-tests.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #