-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Add envsubst as prerequisite in developer guide #4025
📖 Add envsubst as prerequisite in developer guide #4025
Conversation
Hi @Insullone. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Would be good to add a comment that GNU gettext is insufficient (we've noticed some parsing differences in AWS templates, for example). |
@randomvariable Sure, no problem. |
Add envsubst in Chapter 'Developer Guide' of the book. Also update corresponding instructions using envsubst.
598d8d8
to
af54d22
Compare
/retest |
1 similar comment
/retest |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone v0.3.x |
Add envsubst in Chapter 'Developer Guide' of the book.
Also update corresponding instructions using envsubst.
Fixes #4012