-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Mark specific KCP machines with delete annotation for scaling down #4019
✨ Mark specific KCP machines with delete annotation for scaling down #4019
Conversation
…eleted with delete annotation
Hi @furkatgofurov7. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @fabriziopandini |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
This is going to go in the next patch release
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test pull-cluster-api-test-release-0-3 |
@vincepri my apologies, github UI was a bit slow, so I re-triggered the test again :) |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Adds a possibility to mark a specific control plane Machine to be deleted by a KCP when one or multiple machines are annotated by
delete-machine
annotation.This PR:
Backport of #3948