-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Remove deprecated Bootstrap Data #4000
⚠️ Remove deprecated Bootstrap Data #4000
Conversation
27f48f5
to
cbc3401
Compare
/milestone v0.4.0 |
@CecileRobertMichon thanks for this PR! |
@CecileRobertMichon do you need to run |
cbc3401
to
ed9029b
Compare
@CecileRobertMichon: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: Machine.Spec.Bootstrap.Data and KubeadmConfigStatus.BootstrapData were deprecated in v1alpha3 in favor of Bootstrap.DataSecretName. This PR removes the deprecated types and all references to them in the codebase and docs.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #