Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Remove unused MachinePool deployment strategy #3990

Merged
merged 1 commit into from
Dec 4, 2020
Merged

⚠️ Remove unused MachinePool deployment strategy #3990

merged 1 commit into from
Dec 4, 2020

Conversation

CecileRobertMichon
Copy link
Contributor

What this PR does / why we need it: MachinePool spec has MachineDeploymentStrategy which is unused. We don't know if all machine pool implementors will be able to replicate the behavior of MachineDeployment. Also, any changes made to MachineDeploymentStrategy spec will also alter the spec of machine pool, and we don't want that. For now, this removes deployment strategy from the MachinePool spec. We might consider adding a MachinePool specific deployment strategy later on if there is a contract between providers to support certain strategies.

This is technically a breaking change so marking it as so but the Strategy was never used so this won't change any behavior (and MachinePools are still in exp).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3813

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 3, 2020
@CecileRobertMichon
Copy link
Contributor Author

/cc @shysank @devigned

@k8s-ci-robot k8s-ci-robot requested a review from devigned December 3, 2020 23:14
@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: GitHub didn't allow me to request PR reviews from the following users: shysank.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @shysank @devigned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vincepri
Copy link
Member

vincepri commented Dec 3, 2020

/lgtm

@vincepri
Copy link
Member

vincepri commented Dec 3, 2020

/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Dec 3, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2020
@CecileRobertMichon
Copy link
Contributor Author

/cc @mytunguyen

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 3, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 3, 2020 •
edited
Loading

@CecileRobertMichon: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-apidiff-main 207aadd link /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2020
devigned
devigned approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@detiber
Copy link
Member

detiber commented Dec 4, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8437691 into kubernetes-sigs:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devigned devigned devigned approved these changes

@detiber detiber Awaiting requested review from detiber

@justinsb justinsb Awaiting requested review from justinsb

@mytunguyen mytunguyen Awaiting requested review from mytunguyen

Assignees

@devigned devigned

@vincepri vincepri

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

Remove MachineDeploymentStrategy from MachinePoolSpec
6 participants
@CecileRobertMichon @k8s-ci-robot @vincepri @fabriziopandini @detiber @devigned