⚠️ Adapt clusterctl to the new manifests format

[fabriziopandini]

What this PR does / why we need it:
Given that #3042 for v1alpha4 requires single controllers managing all namespaces, this PR removes from clusterctl all the code implemented for managing webhooks in a separated namespace.

NOTE: when we will implement v1alpha3 --> v1alpha4 upgrades, we should manage the proper cleanup of the webhook namespace as a special case (as well as other actions like converting the provider inventory according to the management cluster operator requirements).

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fabriziopandini after the PR has been reviewed.
You can assign the PR to them by writing /assign @fabriziopandini in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fabriziopandini]

/milestone v0.4.0

/hold
for #3985 to merge

[k8s-ci-robot]

@fabriziopandini: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-cluster-api-test-main	b8dc33e	link	/test pull-cluster-api-test-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[fabriziopandini]

@vincepri @wfernandes
I'm eager to cleanup clusterctl code before the management cluster operator work start, but also I'm starting to think that this specific cleanup could prevent us to use clusterctl v0.4.x to create a v1alpha3 cluster, and this could make more complex testing upgrades.
So I'm leaning toward to punt on this cleanup. opinions?
I will open an issue to discuss other cleanups (e.g. removing support for management groups).

[vincepri]

@fabriziopandini Shouldn't we download and use one of the latest releases of clusterctl on v0.3.x to generate v1alpha3 files?

[fabriziopandini]

@vincepri in our E2E tests we are using clusterctl as a library for creating the management cluster, and if the library supports only v1alpha4 manifest it will be impossible to use our current machinery to test v1alpha3 --> v1alpha4

[wfernandes]

to use clusterctl v0.4.x to create a v1alpha3 cluster

Hmm...I think i understand considering we have a non-goal in the caep to not support the installation of v1alpha3 providers using the operator and if clusterctl is going to be modified to rely on the operator, then the E2E cannot use clusterctl to deploy a v1a3 cluster.

Maybe instead we adapt the E2E framework to use a v1alpha3 manifest in test/e2e/data/v1alpha3 to deploy the cluster-api-components.yaml
And if we decide to do something like this we should do the above first before cleaning up clusterctl.

[fabriziopandini]

/close
I'm going to open an issue to track this until we reach an agreement on how to make it possible to test v1alpha3 to v1alpha4

[k8s-ci-robot]

@fabriziopandini: Closed this PR.

In response to this:

/close
I'm going to open an issue to track this until we reach an agreement on how to make it possible to test v1alpha3 to v1alpha4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.