🐛 Properly check errors.Cause when checking with apierrors #3969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
CecileRobertMichon
approved these changes
Dec 1, 2020
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
And when not using the client directly. Signed-off-by: Vince Prignano <[email protected]>
The machine controller deleteNode method is wrapping the error before returning, we're feeding the wrapped error to `apierrors.IsNotFound` which returns false even if the Node has been already deleted. Signed-off-by: Vince Prignano <[email protected]>
vincepri
force-pushed
the
errors-cause03
branch
from
8b025c0 to
079498d
Compare
k8s-ci-robot
added
size/M
| @@ -158,7 +158,7 @@ func TestKubeadmConfigReconciler_Reconcile_ReturnErrorIfReferencedMachineIsNotFo | |||
| }, | |||
| } | |||
| _, err := k.Reconcile(request) | |||
| g.Expect(err).To(HaveOccurred()) | |||
| g.Expect(err).To(BeNil()) | |||
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And when not using the client directly.
Signed-off-by: Vince Prignano [email protected]
What this PR does / why we need it:
This PR targets only
release-0.3because the underlying issue has been fixed in k/k upstream./milestone v0.3.12