Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ MHC external remediation #3882

Merged
merged 1 commit into from
Nov 3, 2020
Merged

✨ MHC external remediation #3882

merged 1 commit into from
Nov 3, 2020

Conversation

arghya88
Copy link
Contributor

What this PR does / why we need it:
This PR implements External Remediation proposal #3190
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3848

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 29, 2020
@arghya88 arghya88 force-pushed the forward-port-mhc branch 2 times, most recently from f10a158 to 9ca8d4b Compare October 29, 2020 09:45
@fabriziopandini
Copy link
Member

/assign @jan-est
/milestone v0.4.0

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: GitHub didn't allow me to assign the following users: jan-est.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @jan-est
/milestone v0.4.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Oct 29, 2020
@fabriziopandini
Copy link
Member

@jan-est PTAL

@jan-est
Copy link
Contributor

jan-est commented Oct 29, 2020

looks good to me

@arghya88 arghya88 changed the title ✨forward-port MHC external remediation ✨Forward Port: MHC external remediation Oct 29, 2020
@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2020
@vincepri vincepri changed the title ✨Forward Port: MHC external remediation ✨ MHC external remediation Nov 2, 2020
vincepri
vincepri approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit ddaedbe into kubernetes-sigs:master Nov 3, 2020
@arghya88 arghya88 deleted the forward-port-mhc branch November 30, 2020 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

Forward-port MHC external remediation to main branch
5 participants
@arghya88 @fabriziopandini @k8s-ci-robot @jan-est @vincepri