🐛 KCP health checks handle consistently errors and check failures #3863
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/milestone v0.3.11 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vincepri this should go in v0.3.11 first |
|
Thanks for the fix @fabriziopandini LGTM, I only have 1 comment. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
| @@ -384,34 +384,32 @@ func (r *KubeadmControlPlaneReconciler) reconcileDelete(ctx context.Context, clu | |||
| logger := r.Log.WithValues("namespace", kcp.Namespace, "kubeadmControlPlane", kcp.Name, "cluster", cluster.Name) | |||
| logger.Info("Reconcile KubeadmControlPlane deletion") | |||
|
|
|||
| // Gets all machines, not just control plane machines. | |||
| allMachines, err := r.managementCluster.GetMachinesForCluster(ctx, util.ObjectKey(cluster)) | |||
There was a problem hiding this comment.
what about MachinePools?
There was a problem hiding this comment.
This PR is just shuffling things around to fix a bug, but this bit is not changing from what we have currently.
However this is a good point and I open an issue to track that we are missing machine pools here
There was a problem hiding this comment.
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/close |
|
@fabriziopandini: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR fixes KCP not calling reconcileEtcdMembers for deleted machines by handling more consistently errors and check failures (everything is an error)
Which issue(s) this PR fixes:
Fixes: #3860
/assign @sedefsavas
/assign @vincepri