Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱Upgrade corefile migration to v1.0.11 #3853

Merged
merged 1 commit into from
Oct 22, 2020
Merged

🌱Upgrade corefile migration to v1.0.11 #3853

merged 1 commit into from
Oct 22, 2020

Conversation

arghya88
Copy link
Contributor

What this PR does / why we need it:

Upgrade corefile migration to v1.0.11 from v1.0.10

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3851

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 22, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 22, 2020
@arghya88 arghya88 force-pushed the update-corefile branch 2 times, most recently from f9dc4a1 to 34df59e Compare October 22, 2020 16:44
@vincepri
Copy link
Member

@arghya88 Run make modules to update the go module files

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 22, 2020
@vincepri
Copy link
Member

/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Oct 22, 2020
@vincepri
Copy link
Member

@arghya88 After this merges, are you able to open a PR to do the same change against the release-0.3 branch?

@arghya88
Copy link
Contributor Author

@arghya88 After this merges, are you able to open a PR to do the same change against the release-0.3 branch?

Yes sure

@detiber
Copy link
Member

detiber commented Oct 22, 2020

/lgtm
+1 to a backport PR for release-0.3 branch

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2020
vincepri
vincepri approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5ac19dc into kubernetes-sigs:master Oct 22, 2020
@arghya88 arghya88 mentioned this pull request Oct 23, 2020
Merged
@arghya88 arghya88 deleted the update-corefile branch November 30, 2020 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@benmoss benmoss Awaiting requested review from benmoss

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@detiber detiber

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

Update corefile-migration dependency to v1.0.11
4 participants
@arghya88 @vincepri @detiber @k8s-ci-robot