Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖Update spot instances proposal with interruptible label setting #3817

Merged
merged 1 commit into from
Oct 27, 2020
Merged

📖Update spot instances proposal with interruptible label setting #3817

merged 1 commit into from
Oct 27, 2020

Conversation

alexander-demicev
Copy link
Contributor

What this PR does / why we need it:
This PR updates spot instances proposal with an interruptible label setting.

#3504

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 19, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @alexander-demichev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 19, 2020
@k8s-ci-robot k8s-ci-robot requested review from benmoss and ncdc October 19, 2020 14:57
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 19, 2020
JoelSpeed
JoelSpeed reviewed Oct 19, 2020
View reviewed changes
docs/proposals/20200330-spot-instances.md Outdated
Comment on lines 265 to 266
3. Machine looks at the infra machine's status (for interruptible) and adds a label to the node.
4. Machine controller ensures the interruptible label is always present on the Node if Machine.status.interruptible is true.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to have Machine.Status.Interuptible or can we always rely on the InfraMachine status as source of truth? Are we copying this for improved UX?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had originally suggested copying from InfraMachine to Machine, but removed it after chatting with @vincepri (trying to avoid copying when it's not required). We can update this line to say "if InfraMachine.status.interruptible is true".

JoelSpeed
JoelSpeed reviewed Oct 20, 2020
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion for improvement, otherwise LGTM

docs/proposals/20200330-spot-instances.md Outdated
Based on the discussion here https://github.com/kubernetes-sigs/cluster-api/pull/3668 ([1](https://github.com/kubernetes-sigs/cluster-api/pull/3668#issuecomment-696143653), [2](https://github.com/kubernetes-sigs/cluster-api/pull/3668#issuecomment-696862994).) we can do following:
1. User creates InfraMachine with whatever spec field(s) are required for that provider to indicate it's interruptible.
2. Infra provider sets InfraMachine.status.interruptible=true
3. Machine looks at the infra machine's status (for interruptible) and adds a label to the node.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be clearer? I feel like we can probably combine 3 + 4, WDYT?

Suggested change
3. Machine looks at the infra machine's status (for interruptible) and adds a label to the node.
3. Machine controller looks at InfraMachine.status.interruptible and ensures a label is set on the node if it is true.

@JoelSpeed
Copy link
Contributor

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 22, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2020
@ncdc
Copy link
Contributor

ncdc commented Oct 26, 2020

/retest
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2020
@ncdc ncdc mentioned this pull request Oct 26, 2020
Merged
@ncdc
Copy link
Contributor

ncdc commented Oct 26, 2020

/retest

@ncdc ncdc mentioned this pull request Oct 26, 2020
Closed
@alexander-demicev
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 17c482f into kubernetes-sigs:master Oct 27, 2020
@alexander-demicev alexander-demicev deleted the labelproposal branch October 27, 2020 14:10
@alexander-demicev alexander-demicev mentioned this pull request Mar 8, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@benmoss benmoss Awaiting requested review from benmoss

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexander-demicev @k8s-ci-robot @JoelSpeed @ncdc