-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ infrastructure provider DigitaloOcean was renamed to digitalocean (previously do) #3809
⚠️ infrastructure provider DigitaloOcean was renamed to digitalocean (previously do) #3809
Conversation
@prksu: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
i dont think that will cause any breaking
/assign @fabriziopandini |
/test pull-cluster-api-test-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
/retitle |
@fabriziopandini yes, we are also planning to backport this to v0.3 release |
/area clusterctl |
@vincepri for the backporting bits |
Cherry-pick + open a different PR based on /approve |
/milestone v0.4.0 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR rename digitalocean infrastructure provider name from
do
todigitalocean
to be matched with cluster-api-provider-digitalocean manifests labels and clusterctl-settings.jsonWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
/cc @kubernetes-sigs/cluster-api-provider-digitalocean-maintainers