🐛 KubeadmControlPlane should use a live client when listing machines #3759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the client used to get the machines in a cluster, instead of using a cached client which could lag behind when the cluster is under stress or when there are network issues, it uses a live client reader which causes the request to go directly to the API server. Signed-off-by: Vince Prignano <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
How about not using cache for the most part in KCP since the decision of scaling up and down depends on the state the controller see, even in |
|
@sedefsavas Not super sure what you mean, using an uncached client shouldn't be the normal behavior, only critical pieces should make use of it, we might end up overloading the API server |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-cluster-api-verify |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the client used to get the machines in a cluster, instead
of using a cached client which could lag behind when the cluster is
under stress or when there are network issues, it uses a live client
reader which causes the request to go directly to the API server.
/assign @sedefsavas @fabriziopandini
/milestone v0.3.11