Add an optional provider-components flag to clusterctl delete cluster
#362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/assign @k4leung4 @roberthbailey |
|
lgtm |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
jayunit100
pushed a commit
to jayunit100/cluster-api
that referenced
this pull request
Jan 31, 2020
…gment Change network name for CAPV e2e tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds an override flag for the path to the provider-components when running
clusterctl delete cluster. This is needed because delete needs to be able to run the same provider components on the minikube cluster. Note that this flag is optional as we will save the provider components to the cluster, however, in the event that there is an error saving to the cluster, the cluster is in an invalid state of being almost deleted, or some other issue this will be potentially useful.Special notes for your reviewer:
Release note:
@kubernetes/kube-deploy-reviewers